filter empty sql to avoid IndexOutOfBoundException #246
Conversation
Signed-off-by: ⚆ Trung Nguyen <[email protected]>
| @@ -102,6 +102,7 @@ public Flux<H2Result> execute() { | |||
| Assert.requireTrue(!this.bindings.open, "No unfinished bindings!"); | |||
|
|
|||
| return Flux.fromArray(this.sql.split(";")) | |||
| .filter(sql -> !sql.trim().isEmpty()) | |||
There was a problem hiding this comment.
I think there is a bigger problem.
split(";") cannot be used to break SQL into separate statements properly. This character may be used in comments, various types of character string literals, and quoted identifiers.
There was a problem hiding this comment.
You are right. If we remove the split, would it there be any serious implication? Mainly backward compatibility IMO.
Or we need to have a more sophisticated split than just string split.
There was a problem hiding this comment.
It would be so great to be able to make use of H2's internal parsing utils instead of us having to make a dance around H2 externally. Too bad, I wasn't able to convince @katzyn to bring this project closer to H2.
There was a problem hiding this comment.
Can we consider this fix as an interim patch while having much more careful changes to deal with ; parsing?
There was a problem hiding this comment.
I stumbled over the semicolon problem and opened an issue before I happened to have a look here and saw this discussion.
resolves #245
Make sure that: